facebook/fbthrift

No sudo on Mac

elharo opened this issue · 1 comments

elharo commented

The README suggests building with

$ sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive fbthrift

However this fails on Mac OS X from the last several versions:

Error: Running Homebrew as root is extremely dangerous and no longer supported.
As Homebrew does not drop privileges on installation you would be giving all
build scripts full access to your system.
Command '['brew', 'install', 'autoconf', 'automake', 'boost', 'cmake', 'double-conversion', 'icu4c', 'libevent', 'libsodium', 'libtool', 'lz4', 'ninja', 'openssl@1.1', 'xz', 'zlib', 'zstd']' returned non-zero exit status 1.
!! Failed

I'm checking to see whether this works if it's simply run without sudo.

vitaut commented

You no longer need to pass sudo when installing dependencies and we'll update the readme shortly. Thanks for reporting!