Node.js deprecation warning in github action
kalwalt opened this issue · 6 comments
while testing a new build script for Emscripten see issue #67 i noticed this warning:
[cmake-build (Ubuntu - Emscripten, ubuntu-latest, Debug, emcc, em++, Ninja)](https://github.com/kalwalt/igl/actions/runs/7783677004/job/21222620454)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v2, SimenB/github-actions-cpu-cores@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
I think actions/checkout need to be upgraded infact the latest is v4 and the igl scripts use v3.
The last commits doesn't solve completely the issue because the source of the problem reside in the humbletim/setup-vulkan-sdk see this PR humbletim/setup-vulkan-sdk#12 So until this package will not be upgraded the issue will stay.
@kalwalt I noticed there're some recent changes in https://github.com/humbletim/setup-vulkan-sdk/tree/fix-github-actions-deprecations. Once it is merged, please go ahead and create a PR here.
@kalwalt I noticed there're some recent changes in https://github.com/humbletim/setup-vulkan-sdk/tree/fix-github-actions-deprecations. Once it is merged, please go ahead and create a PR here.
Yes of course! 🙂
@corporateshark the PR about setup-vulkan-sdk was merged, so i will send a PR with the updates when i have a bit of time.
@kalwalt Thank you so much!
Merged in b4798a5.