facebook/yoga

min-width in percent isn't calculated against parent node

vadimdemedes opened this issue · 1 comments

It seems that Yoga doesn't calculate min-width against parent node's width. Interestingly it occurs only when using percentage, e.g. 50%.

P.S. Thank you for the amazing library! Ink is a very happy user!

Report

Issues and Steps to Reproduce

See https://codesandbox.io/s/vv0rlkokz7 for reproduction. childNode's width should be half of parentNode's width, but it seems to be half of rootNode's width for some reason.

Expected Behavior

It should calculate 50% min-width against parent node's width.

Actual Behavior

It calculates min-width against root node.

Link to Code

https://codesandbox.io/s/vv0rlkokz7

Hi @vadimdemedes,

thanks for reporting that bug, I just pushed a PR for the fix. Unfortunately that fix reveals a previous bug by failing other unit tests. Let's see how the current maintainer decide on having this merged.