facebookresearch/beanmachine

Instructions at README.md fail

gafter opened this issue · 2 comments

Issue Description

Following the instructions in README.md fails the last, test, step.

Steps to Reproduce

Follow instructions at README.md

Expected Behavior

Tests Pass

System Info

Please provide information about your setup

  • PyTorch Version (run print(torch.__version__)
  • Python version Python 3.7.10 (default, Feb 26 2021, 18:47:35); [GCC 7.3.0] :: Anaconda, Inc. on linux

Additional Context

Following the instructions from scratch on a Macbook Pro laptop.

Actual Behavior

root@af6d9521b3e0:/project# pytest .
=================================================================== test session starts ===================================================================
platform linux -- Python 3.7.10, pytest-7.1.1, pluggy-1.0.0
rootdir: /project, configfile: pyproject.toml
collected 0 items / 1 error                                                                                                                               

========================================================================= ERRORS ==========================================================================
______________________________________________________________ ERROR collecting test session ______________________________________________________________
src/beanmachine/ppl/conftest.py:6: in <module>
    import beanmachine.ppl as bm
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/__init__.py:9: in <module>
    from .diagnostics import Diagnostics
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/diagnostics/__init__.py:11: in <module>
    from beanmachine.ppl.diagnostics.diagnostics import Diagnostics
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/diagnostics/diagnostics.py:14: in <module>
    from beanmachine.ppl.inference.monte_carlo_samples import MonteCarloSamples
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/inference/__init__.py:6: in <module>
    from beanmachine.ppl.inference.bmg_inference import BMGInference
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/inference/bmg_inference.py:16: in <module>
    from beanmachine.ppl.compiler.fix_problems import default_skip_optimizations
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/compiler/fix_problems.py:35: in <module>
    from beanmachine.ppl.compiler.fix_requirements import RequirementsFixer
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/compiler/fix_requirements.py:21: in <module>
    from beanmachine.ppl.compiler.internal_error import InternalError
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/compiler/internal_error.py:13: in <module>
    import beanmachine.ppl.compiler.ast_tools as ast_tools
/opt/conda/lib/python3.7/site-packages/beanmachine/ppl/compiler/ast_tools.py:17: in <module>
    import black
E   ModuleNotFoundError: No module named 'black'
================================================================= short test summary info =================================================================
ERROR  - ModuleNotFoundError: No module named 'black'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
==================================================================== 1 error in 1.07s =====================================================================
root@af6d9521b3e0:/project# 

Thank you for the bug report. We're fixing the issue in #1389. In the very short run, you should be able to run the tests by installing Bean Machine with its test dependencies:

python -m pip install "beanmachine[test]"

In the very short run, you should be able to run the tests by installing Bean Machine with its test dependencies:

python -m pip install "beanmachine[test]"

A slight improvement:

python -m pip install "beanmachine[test]"
pytest src

If you use plain Jane venv and brew to install Eigen and boost, pytest . will try to run tests for all of the packages installed in your environment.