falcosecurity/falcoctl

falcoctl registry login: enhancements

alacuku opened this issue · 18 comments

falcoctl registry login is used to login to a remote OCI registry. It accepts an argument which is the domain name of the registry and prompts the user to input its username and password:

$ falcoctl registry login my-regirstry.me
Username: my-username
Password: my-password

The credentials passed to the command are saved in /home/user/.docker/config.json. Subsequent calls to falcoctl registry commands will retrieve and use those credentials.

What would you like to be added:
The following flags/options should be added to the login command:

  • -p, --password: registry password or identity token used for authentication;
  • -u, --username: registry username used for authentication.

Command behavior

When no flags are passed to the falcoctl registry login command it must prompt the user for credentials. Otherwise, it will use the flag values and prompt the user for the missing ones.

Why is this needed:
This feature allows the falcoctl registry login to be scriptable.

/good-first-issue

@alacuku:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

/remove-lifecycle stale

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

/remove-lifecycle stale

I'm happy to work on this

/assign

A community member is already working on this: https://kubernetes.slack.com/archives/CMWH3EH32/p1678019940711779

Could you please coordinate with him and let me know here?

Thanks!

Of course @alacuku ! :)

poiana commented

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale