legume/gme didn't install
alexysong opened this issue · 6 comments
Not sure if it's just me, can someone check? Here is what I did:
download source zip. unzip. in console, enter the directory, and type pip install . The package installs fine, but the sub-directiory gme/ is missing in the installed packaage.
(Probably) fixed in 5048d76.
As Ian pointed out to me yesterday, every sub-folder should have an __init__.py. I added this and your method of installation seems to work on my PC (although I didn't explicitly check that it didn't before). Let me know if this solves your issue.
Works now. THanks!
Interesting. I didn't realize that __init__.py affects which folders are included during installation.
@alexsong19 while this package is still under development, it may be more convenient for you to "install" it via git clone git@github.com:fancompute/legume.git into some folder in your home or user directory. You can then add this folder to your PYTHONPATH environment variable, e.g. export PYTHONPATH=/path/to/the/location/of/legume, and you can import as if it were installed via pip. You can periodically update the package as changes are made in the main repo by issuing the git fetch or git pull commands.
Yeah that's also a good option, just a note that you should preferentially do export PYTHONPATH=$PYTHONPATH:/path/to/the/location/of/legume so that if you already have other locations in your PYTHONPATH they will also be preserved.
Also, you'll need to do this every time you open a new terminal, and if you don't want to do this, then you have to add that command to your ~/.bashrc file, or whatever is the equivalent to that for the terminal you're using.
Thanks for the suggestions!
I am using windows, for me I find it easy enough just to install it to my venv, like any other packages, including my own packages. Then it's always available to me. I will be using it in different structure simulations in different directories.
@momchilmm Maybe update the version number with fixes?