figshare/Total-Impact

fix twitter button to use pretty urls

Closed this issue · 5 comments

right now still uses report.php?

fixed

Jason fixed it in master, I did it in CleanURL

On Nov 21, 2011, at 1:05 PM, Heather Piwowar wrote:

right now still uses report.php?


Reply to this email directly or view it on GitHub:
#57

CleanURL has been merged in, so we shoudn't need to worry about keeping
it up to date, right?

On 11/21/2011 04:56 PM, dartar wrote:

Jason fixed it in master, I did it in CleanURL

On Nov 21, 2011, at 1:05 PM, Heather Piwowar wrote:

right now still uses report.php?


Reply to this email directly or view it on GitHub:
#57


Reply to this email directly or view it on GitHub:
#57 (comment)

I was not sure about the plans: is the CleanURL branch merged and dead or are we going to use it to experiment on dev.total-impact.org?

On Nov 21, 2011, at 1:58 PM, Jason Priem wrote:

CleanURL has been merged in, so we shoudn't need to worry about keeping
it up to date, right?

On 11/21/2011 04:56 PM, dartar wrote:

Jason fixed it in master, I did it in CleanURL

On Nov 21, 2011, at 1:05 PM, Heather Piwowar wrote:

right now still uses report.php?


Reply to this email directly or view it on GitHub:
#57


Reply to this email directly or view it on GitHub:
#57 (comment)


Reply to this email directly or view it on GitHub:
#57 (comment)

I think it's dead, since the cleanURL problem is mostly solved. We can
always make new branches for later experiments. Branches in git are
nicely disposable :)

On 11/21/2011 05:28 PM, dartar wrote:

I was not sure about the plans: is the CleanURL branch merged and dead or are we going to use it to experiment on dev.total-impact.org?

On Nov 21, 2011, at 1:58 PM, Jason Priem wrote:

CleanURL has been merged in, so we shoudn't need to worry about keeping
it up to date, right?

On 11/21/2011 04:56 PM, dartar wrote:

Jason fixed it in master, I did it in CleanURL

On Nov 21, 2011, at 1:05 PM, Heather Piwowar wrote:

right now still uses report.php?


Reply to this email directly or view it on GitHub:
#57


Reply to this email directly or view it on GitHub:
#57 (comment)


Reply to this email directly or view it on GitHub:
#57 (comment)


Reply to this email directly or view it on GitHub:
#57 (comment)