Missing User Channel Tests
robmoffat opened this issue · 4 comments
robmoffat commented
Just looking at the spec rn and we have a few tests in 2.0 for user channels that aren't implemented:
UCFilteredUsageJoin
UCFilteredUsageNoJoin
Could you and @ gaganahluwalia take a look?
thanks!
kriswest commented
also these are still hanging out waiting for you @rob Moffat
***@***.***>
finos/FDC3#864
finos/FDC3#865
They'll need merging into/integrating into your updated file format for the
tests. 2.0 doessn't need amintainer review as its going into another PR
they need to accept (your one).
K
…On Mon, 16 Jan 2023 at 16:01, Rob Moffat ***@***.***> wrote:
Just looking at the spec rn and we have a few tests in 2.0 for user
channels that aren't implemented:
UCFilteredUsageJoin
UCFilteredUsageNoJoin
Could you and @ gaganahluwalia take a look?
thanks!
—
Reply to this email directly, view it on GitHub
<#169>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM7PBBSZWC7HVJVWLPQ24DWSVWEXANCNFSM6AAAAAAT444PKI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Kris West *he • him*
*Principal Engineer*
[image: Finsemble] <https://finsemble.com/>
***@***.***
finsemble.com
Joe-Dunleavy commented
@robmoffat UCFilteredUsageJoin
is there it's just under the name of UCFilteredUsageLeave
, which should show up as a duplicate but is actually two different tests. The other one I can't find it anywhere.
Gagan and I will fix these today
Joe-Dunleavy commented
@robmoffat UCFilteredUsageNoJoin
is actually a duplicate of BasicCH2
, which would explain why it's not there. We can remove UCFilteredUsageNoJoin
from the test definitions
Joe-Dunleavy commented
Fixed: #171