fitztrev/laravel-html-minify

Proposal - Do not minify when running tests

Closed this issue · 4 comments

If the Laravel environment is set to "testing" I don't think we should run tests.
Because on the magnification if a test fails due to some error in one of my views I get an error like this Parse error: syntax error, unexpected 'asd' (T_STRING), expecting ',' or ';' in /Users/thomaswelton/Sites/laravel/app/storage/views/9da08227d3fbc0bdaa75a09b9bd81100 on line 1
Which isn't super useful as the real filename for the view is not shown.

Or maybe add a config file where we can turn minification on or off, or whilelist or black list directories of views we don't want to be processed.

I like this. I've been thinking of adding a config file for it, like you
said, to turn it on/off on a per-environment basis.
On Nov 14, 2013 7:10 AM, "Thomas Welton" notifications@github.com wrote:

Or maybe add a config file where we can turn minification on or off, or
whilelist or black list directories of views we don't want to be processed.


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-28479030
.

This has been added. You should now be able to add an environment config to disable the package during your tests.

Awesome thanks

On 11 Dec 2013, at 04:24, Trevor Fitzgerald notifications@github.com wrote:

This has been added. You should now be able to add an environment config to disable the package during your tests.


Reply to this email directly or view it on GitHub.