fixthestatusquo/proca

Formatting / Formatter

aaronelliotross opened this issue · 4 comments

aaronelliotross commented

The package.json contains a script to format the code - but it fails with two errors. The second error is problems with dprint exploding on out of bounds memory access.

What do you all think about returning to prettier, which seems more stable?

❯ yarn format
yarn run v1.22.15
$ nice -20 dprint fmt
Error formatting /home/aaron/fixthestatusquo/proca-widget/src/components/field/Organisation.js. Message: Line 106, column 33: Expected ',', got ':'

leMouseDown = (event: React.Mou
~
Critical error formatting /home/aaron/fixthestatusquo/proca-widget/d/birds/minimumbasicseeds/index.js. Cannot continue. Message: Originally panicked in dprint-plugin-typescript, then failed reinitialize. This may be a bug in the plugin, the dprint cli is out of date, or the plugin is out of date.
Original error: RuntimeError: out of bounds memory access

tttp commented

Hi,

ok, prettier is actually fast enough anyway, let's revert indeed!

tttp commented

you want to take credit or want me to do it @aaronelliotross ?

aaronelliotross commented

I'll take a swing at it sure.

tttp commented

@aaronelliotross can you add in your PR a "fix #832" or whatever the id of the issue related to the PR?

that way, github will automatically close it (I know, it's magic ;)

thanks for the reformating! I'll keep an eye on it, we might need to exclude src/locales, as weblate seems to have a different idea of how it should be formatted than prettier.

to be continued...

X+