!important - is an issue. Don't do it.
Opened this issue · 1 comments
pmario commented
!important - is "toxic". You can't get rid of it. So don't use it! ... If you have to, the concept is wrong and needs to be started from scratch.
It's not only me that says that. Have a look at this video. https://www.youtube.com/watch?v=CHyPGSpIhSs I think it explains it very well. ..
There are some problems with the TW default style sheets. The default rules in there are already a bit too specific to make them easy to be reused. ... That causes most of the problems we have already with styling our theme.
If your theme will have 1 !important left, it will cause problems for users.
flancast90 commented
Thanks for the feedback @pmario. I have already started to work on this on
my end. Much of the TW GG have been helping me work to add a palette to the
theme, so that palette tweaking works. This would also prevent the need for
!important declarations, such that I could just define parts as the palette
colors.
Thanks again for your feedback!
…On Fri, Aug 27, 2021 at 8:31 AM Mario Pietsch ***@***.***> wrote:
!important - is "toxic". You can't get rid of it. So don't use it! ... If
you have to, the concept is wrong and needs to be started from scratch.
It's not only me that says that. Have a look at this video.
https://www.youtube.com/watch?v=CHyPGSpIhSs I think it explains it very
well. ..
There are some problems with the TW default style sheets. The default
rules in there are already a bit too specific to make them easy to be
reused. ... That causes most of the problems we have already with styling
our theme.
If your theme will have 1 !important left, it will cause problems for
users.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR2EVEHJJXCGW2MZBCBZT2TT66ASZANCNFSM5C5OOW4Q>
.