Don't use recursive packaging

Question

Don't use recursive packaging

ChALkeR opened this issue 9 years ago · 9 comments

o_O O_o

angular-formly-templates-ionic 1.2.0 includes an examples dir.
Those examples also include angular-formly-templates-ionic itself in the www/lib dir.
Those copies also include an examples dir.
…
The total unpacked size is 215.8 MiB.

examples dirs:

./angular-formly-templates-ionic/examples
./angular-formly-templates-ionic/examples/stackedLabels/www/lib/angular-formly-templates-ionic/examples
./angular-formly-templates-ionic/examples/floatingLabels/www/lib/angular-formly-templates-ionic/examples
./angular-formly-templates-ionic/examples/inlineLabels/www/lib/angular-formly-templates-ionic/examples
./angular-formly-templates-ionic/examples/inlineLabels/www/lib/angular-formly-templates-ionic/examples/stackedLabels/www/lib/angular-formly-templates-ionic/examples
./angular-formly-templates-ionic/examples/inlineLabels/www/lib/angular-formly-templates-ionic/examples/floatingLabels/www/lib/angular-formly-templates-ionic/examples

angular-formly-templates-ionic copies:

./angular-formly-templates-ionic/
./angular-formly-templates-ionic/examples/stackedLabels/www/lib/angular-formly-templates-ionic
./angular-formly-templates-ionic/examples/floatingLabels/www/lib/angular-formly-templates-ionic
./angular-formly-templates-ionic/examples/inlineLabels/www/lib/angular-formly-templates-ionic
./angular-formly-templates-ionic/examples/inlineLabels/www/lib/angular-formly-templates-ionic/examples/stackedLabels/www/lib/angular-formly-templates-ionic
./angular-formly-templates-ionic/examples/inlineLabels/www/lib/angular-formly-templates-ionic/examples/floatingLabels/www/lib/angular-formly-templates-ionic

Answer 1 · 2015-08-18T08:44:39.000Z

Removing the nested examples/*/www/lib/angular-formly-templates-ionic/examples directories decreases the unpacked size 4 times (by 163.2 MiB), from 215.8 MiB to 52.6 MiB.

Answer 2 · 2015-08-18T13:39:00.000Z

Are you using bower or npm? Bower ignores these examples directories and doesn't include them when you install the package. I'll add a npmignore though to exclude the examples for npm

Answer 3 · 2015-08-18T13:53:09.000Z

npm. And that's in your git.

Answer 4 · 2015-08-18T13:54:21.000Z

See https://github.com/formly-js/angular-formly-templates-ionic/tree/v1.2.0/examples/inlineLabels/www/lib/angular-formly-templates-ionic/examples/floatingLabels/www/lib/angular-formly-templates-ionic/examples/select/www/lib

Answer 5 · 2015-08-18T14:13:40.000Z

Right, but the examples are there for testing purposes and it's not really possible to ignore them when pushing a release. I can clean up those examples, but I keep them there for testing purposes.

Answer 6 · 2015-08-18T15:06:42.000Z

@mhartington Do they have to be nested and duplicated several times for testing purposes? This is one link: https://github.com/formly-js/angular-formly-templates-ionic/tree/v1.2.0/examples/inlineLabels/www/lib/angular-formly-templates-ionic/examples/floatingLabels/www/lib/angular-formly-templates-ionic/examples/select/www/lib

Ok then.

Answer 7 · 2015-08-18T15:08:02.000Z

No not really (was an early test to be honest). Like I said, I'll can clean up the examples and get rid of the nested code.

Answer 8 · 2015-09-05T14:59:31.000Z

Btw, they are still there in git.
What is the reason for keeping them, again?

Answer 9 · 2015-09-05T15:18:57.000Z

Yes I know. On my list of priorities, this one is low on it.
Most people are using some sort of package manager so I'm not expecting anyone to just download a zip from github.

I will get to it when I have time.