fossology/Nirjas

Comment terminates on special character

Aman-Codes opened this issue · 8 comments

Aman-Codes commented

Description

Nirjas terminates the comment on occurrence of any special character out of !$%&{}~`"'| for all languages

How to Test

Create a c file and add a single line comment which contains any special character out of !$%&{}~`"'|

How to Resolve

Changing regex from (\/\/\s*[\w #\.()@+-_*\d]*) to (\/\/\s*[\w #\.()@!-~*\d]*)

GMishx commented

I am currently working on it. I changed the regex from list of acceptable characters to a simple .*

Will have to test if it fails somewhere.

  • 👍1
Aman-Codes commented

I am currently working on it. I changed the regex from list of acceptable characters to a simple .*

Sounds good

codeakki commented

May i work on this issue I'm a newbie nd want to explore how open source community works nd want to implement my learning skiils

GMishx commented

Thanks for your interest @codeakki but #28 already solves it.

codeakki commented

@GMishx sir is thier is anything where i start my contribution in these project or organisation for ne

codeakki commented
hastagAB commented

Hi @codeakki, You can start with these:

[Good first issues in FOSSology]

[Open issues in Atarashi]

Currently Nirjas has no unattended issues open but you can explore the project to find some.

GMishx commented

Thanks for the inputs @hastagAB . I have just created another issue fossology/atarashi#77 and would like to add it to your list.