why is this ofxOpenVR2?

[elliotwoods]

Hey there!

I noticed there are a few extra functions than ofxOpenVR

ofxAddonName2 is generally reserved for when you completely rewrite your own implementation in a way that strongly diverges from ofxAddonName. I was excited because ofxBlahBlah2 often means that somebody looked at the original implementation and decided they could do it much better from scratch.

In this case, it seems that it's a fork with minor additions to the other one.
Why not just fork the original and PR functions back in?

It looks like you've made some good additions (e.g. handling the standalone trackers), whilst keeping most of the code identical to before. I think this would be a good candidate for simply merging with the original (which is a much more popular addon).

Also I can see that you haven't touched this for 3 years (most people haven't touched oF for 3 years I know). So this is more of a curiosity/conversation than an actual call to action.

Thank you for your contributions.

Elliot

[fred-dev]

Hi, thanks for the email, yes you are right this is largely the same as the original repo, sorry to disappoint you that it was not a better implementation of openVR for OF :( Some of the reasoning was personal, I was alternating between some variations while I was working and wanted to keep things separate, a private repo/branch would have been more appropriate. The larger difference, (although I guess not enough to warrant the 2 suffix), is that I precompiled openVR as libs in this repo, rather than including the openVR repo as a submodule. This made things a little more portable and at the time meant I could run VR on OSX from OF, which I could not work out how to do with the submodule. This meant that to use up to date versions of openVR meant rebuilding the libs, whereas for the original ofxOpenVR this mostly just meant updating the submodule, this seemed a big difference to me, although it was not in the actual code. I still use OF now and then, and even VR through ofxOpenVR, although it has been some time since I did any actual work on it. I will check between my fork of ofxOpenVR and my ofxOPenVR2 repo for functional differences and delete the 2 repo, I know that GH is a public resource but in a hurry I sometimes use it as a personal sketchpad and dont clean up. Thanks for making contact, I will get a chance to clean things soon. Also many thanks for your contributions to OF! I have used a lot of your code in my projects. If you dont mind me asking what have you been using instead of OF? Cheers Fred

…

On 15 Jan 2022, at 23:31, Elliot Woods ***@***.***> wrote: Hey there! I noticed there are a few extra functions than ofxOpenVR ofxAddonName2 is generally reserved for when you completely rewrite your own implementation in a way that strongly diverges from ofxAddonName. I was excited because ofxBlahBlah2 often means that somebody looked at the original implementation and decided they could do it much better from scratch. In this case, it seems that it's a fork with minor additions to the other one. Why not just fork the original and PR functions back in? It looks like you've made some good additions (e.g. handling the standalone trackers), whilst keeping most of the code identical to before. I think this would be a good candidate for simply merging with the original (which is a much more popular addon). Also I can see that you haven't touched this for 3 years (most people haven't touched oF for 3 years I know). So this is more of a curiosity/conversation than an actual call to action. Thank you for your contributions. Elliot — Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMD3FI2TNKKF2CK6BQ5V2LUWFSI5ANCNFSM5MA6DSKA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.

[elliotwoods]

Please don't delete it! I know that merging can be complicated and takes time (especially for a project you haven't touched in years)
I'd just add some notes into the readme explaining the differences.

[elliotwoods]

The tool I mostly use for the past couple of years is Fusion 360. I haven't been making projects where computer graphics are present in the output, so my tool choices can be quite different to many creative coders.

I still use oF underneath my Rulr framework for all calibration related tasks. I've made quite a workable world there (which deviates quite a bit from standard oF style). I've been considering migrating Rulr from oF to Unreal for a few reasons (user-base, compiling, interface, graphics), but I haven't made the jump yet.

Wherever possible, I make projects in javascript. node backend + web front-end with relevant libraries, e.g. bootstrap, jquery, three.js, golden layout, plotly, etc.