ftlabs/fruitmachine

bower dependencies

kavanagh opened this issue · 5 comments

kavanagh commented

package.json says Fruitmachine depends on event, model, util and extend...

{
 ...
"dependencies": {
    "event": "git://github.com/wilsonpage/event.git",
    "model": "git://github.com/wilsonpage/model.git",
    "utils": "git://github.com/wilsonpage/utils.git",
    "extend": "git://github.com/wilsonpage/extend.git"
  }
}

... but bower.json does not have these dependencies.

Is this correct? If so, what's the rationale. Sorry, it's not obvious to me.

If bower.json had it's main property as build/fruitmachine.js I could understand as that file doesn't seem to have dependencies. I assume having the entry point as lib/fruitmachine.js is to promote the use of the library as a CommonsJS Module (ie. on node or via Browserify).

wilsonpage commented

If installed with Bower I think it would have to point towards the built version, otherwise require()s for dependencies would break when Browserifying. @matthew-andrews has been working on removing the built version from the repo, so we may encounter issues here :/

wilsonpage commented

In summary, the bower.json file is pointing to the wrong main file.

matthew-andrews commented

Arghghghghg. bower.

OK. I've proposed a fix for bower in the short term here:
#59

Longer term, given the FT is moving to towards bower I think it would be best to add bower.json files to each of them and fix that as part of my nocompiled branch: https://github.com/ftlabs/fruitmachine/tree/nocompiled.

wilsonpage commented

Is it possible for bower to work with Browserify nested deps?

On Wed, Jan 15, 2014 at 2:04 PM, Matt Andrews notifications@github.comwrote:

Arghghghghg. bower.

OK. I've proposed a fix for bower in the short term here:
#59 #59

Longer term, given the FT is moving to towards bower I think it would be
best to add bower.json files to each of them and fix that as part of my
nocompiled branch: https://github.com/ftlabs/fruitmachine/tree/nocompiled.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/58#issuecomment-32363605
.

matthew-andrews commented

Yes, I believe so...

On 15 January 2014 14:06, Wilson Page notifications@github.com wrote:

Is it possible for bower to work with Browserify nested deps?

On Wed, Jan 15, 2014 at 2:04 PM, Matt Andrews notifications@github.comwrote:

Arghghghghg. bower.

OK. I've proposed a fix for bower in the short term here:
#59 #59

Longer term, given the FT is moving to towards bower I think it would be
best to add bower.json files to each of them and fix that as part of my
nocompiled branch:
https://github.com/ftlabs/fruitmachine/tree/nocompiled.

—
Reply to this email directly or view it on GitHub<
https://github.com/ftlabs/fruitmachine/issues/58#issuecomment-32363605>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/58#issuecomment-32363755
.