gbouras13/pharokka

Wrong attribute - PyHMMER module

Closed this issue · 2 comments

valentynbez commented
  • pharokka version: 1.2.1
  • Python version: 3.10.10
  • Operating System: CentOS8
  • PyHMMER version: 0.10.4

During PyHMMER run code refers to hit.phrog attribute. pyhmmer.plan7.Hit object doesnt have attribute phrog, therefore code crashes.
To get the phrog name and compare it hit.name.decode() should be used.
This was a tricky one as it only happened during a very big annotation job.

gbouras13 commented

Thanks for spotting the bug @valentynbez and for the PR - just checking, this would be for v1.6.1?

valentynbez commented

Yes, code in these sections remained unchanged since 1.2.1.
I just didn't update my environment for a long time.

  • 👍1