Refactor basemaps.py and add tests
jdbcode opened this issue · 7 comments
@giswqs, I'm going to keep this open until I've made it completely through basemaps.py - I anticipate a couple more PRs for it.
Sorry. The Issue was automatically closed when referenced in a PR.
Bummer that it does that. With our internal review system I'm used to being able to link issues to pull requests and optionally designate as "fixes" to close the issue(s).
I looked briefly for changing the default behavior, but it does not appear to be an option: https://github.com/orgs/community/discussions/23476
It also seems there is not a parent --> child or "blocked by" issue hierarchy system.
After more than three years, GitHub still has not implemented this simple feature. Unbelievable!
App to compare 250 map layers; the provider sectioning in dropdown is kind of nice: https://mc.bbbike.org/mc/
Putting this here as a bookmark, the UI would not actually be handled by basemaps.py probably.
Looks nice! They also have Google basemaps🤓
:) It's the "development only" tiles though... they make it so hard!