Test mock ontology term replacement for new SOP
kltm opened this issue · 6 comments
A place to put results and discussion of a mock run of the new minerva outage SOP.
Related to #456
Tagging @vanaukenk @balhoff
For perusal, what a simulated run on noctua-models master might look like: https://github.com/geneontology/noctua-models/commits/issue-minerva-476-test-replacement
Pinging @vanaukenk @balhoff
So far, so good! All of the changes I checked in the diff make sense and fix things that need to be fixed :-)
One issue that I'm going to raise on today's Pathways2GO monthly meeting, though, is the consequence of updates to imported Reactome models. All the updates make sense, but if we implement the script as is, the models at GO will be changed from what was originally imported and we had said that we didn't want to modify imported Reactome models at GO, i.e. Reactome would make changes locally and then we'd re-import.
I just want to make sure everyone involved in the Pathways2GO project is aware of this and, if we don't want the updates on Reactome models, we'll have to figure out how to modify the update process accordingly.
Stay tuned....
Decision from the 2022-04-13 Pathways2GO call:
For the time being, GO will update ontology terms in all models with the regular Noctua maintenance outages.
If, in the future, we find that we're diverging too much from Reactome's quarterly releases and this presents potential confusion for users, we can revisit and think about ways to exclude Reactome models from the updates.
Also noted on the call was the known desire for a more human readable diff in the next iteration of this project.
Looks good.