geneontology/minerva

Cannot Edit title when copying a copy

tmushayahama opened this issue · 11 comments

After copying a copy, open that copy then try to copy that copy and edit a title. It will not edit as seen below, but prepend it with "Copy of "

image

response
image

tagging @balhoff @vanaukenk @ukemi

If you copy a model and do not provide a title, it gets an autogenerated title "Copy of xxxxx" where xxxxx is the title of the previous model. After the model has been created, changing the title should happen as for any other model. Are you following the same approach for changing a title as usual?

I tested in the graph editor and can't reproduce the problem. I copied a copied model, then opened in graph editor. I used the Model > Edit annotations menu to delete the existing title and add a new one.

not edit title, but making a new copy based on that copy with a new title like in this payload
image

@balhoff lemm just use raw request and not worry about bbop

@balhoff lemm just use raw request and not worry about bbop

Okay! Closing, as this seems to be primarily a client library issue. If we end up needing some specific changes to the Minerva API, let's open another ticket for that.

@balhoff @kltm I have hacked it on my side and should not be the case. It's a Minerva issue and should be fixed on the server side just like any other annotation. If it's following its convention then adding title or state or any other operation is separate "add-annotion" operation not inside copy operation.

@tmushayahama it works fine if you send the add-annotation operation to the right model id. You don't know the new model id until after you execute the copy operation.

@tmushayahama - should I go ahead with testing on noctua-dev or will there be additional updates based on @balhoff 's comment above?

@vanaukenk oh yes, go ahead and test. this should not affect anything. It was just for development purposes

Testing today, 2022-07-07, on noctua-dev, things look okay.

I tested making multiple copies of a source model and tested making a copy of a copy.

kltm commented

@tmushayahama To continue on here, could you put in the JSON object that you're currently building to get the title in?