georgemandis/jekyll-rss-feeds

Trailing slash required on site.url

latentflip opened this issue · 2 comments

Hey,

The feeds have {{ site.url }}{{ post.url }}, but the readme doesn't specify that site.url should have a trailing slash, indeed the example config.yml doesn't have one, which will give a broken feed.

Not sure whether to update the code or the readme, or I would just submit a PR :)

Good catch! Hmm. Can we update the template to accommodate a trailing slash
or not? It would make it more flexible. If not, I guess I'll just update
the README :-)

On Thursday, April 4, 2013, Philip Roberts wrote:

Hey,

The feeds have {{ site.url }}{{ post.url }}, but the readme doesn't
specify that site.url should have a trailing slash, indeed the example
config.yml doesn't have one, which will give a broken feed.

Not sure whether to update the code or the readme, or I would just submit
a PR :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/5
.

Snaptortoise Web Development
snaptortoise.com
503-334-2511

This was introduced with #3 . But I don't understand why 3 was usefull, because Jekyyl doc says

If you use the method described above, please remember that the URLs for all posts and pages contain a leading slash. Therefore, concatenating the site baseurl and the post/page url where site.baseurl = / and post.url = /2013/06/05/my-fun-post/ will result in two leading slashes, which will break links. It is thus suggested that prefixing with site.baseurl only be used when the baseurl is something other than the default of /.

But at the same time it says also :

In Jekyll v1.0, we introduced absolute permalinks for pages in subdirectories. Until v2.0, it is opt-in. Starting with v2.0, however, absolute permalinks will become opt-out, meaning Jekyll will default to using absolute permalinks instead of relative permalinks.

So maybe before 2.0 there was no leading slash ("relative permalinks").