github/issue-metrics

Not all env variables are being checked via the get_env_vars() function

zkoppert opened this issue ยท 3 comments

The design pattern we want to use is to get all env variables from the return of a get_env_vars() call. This is not being used consistently (see functions like get_non_hidden_columns()). We should take the time to comprehensively update to the use of this pattern across all areas of the code.

Thanks to @spier for discovering this issue.

ananta commented

@zkoppert I would love to work on this :)

Great @ananta ! That would be very helpful! Feel free to get started and let me know what support you need.

ananta commented

Hey @zkoppert , I've refactored the code to use get_env_vars() across the app. There's still some room for improvement, but I'd like to get your thoughts on these changes first.