github/janky

Jenkins >= 1.519 returns 201 for successful created jobs

josacar opened this issue · 5 comments

Starting from Jenkins 1.519 returns HTTP/201 for successful created jobs instead of a HTTP/302, so an error is raised and no build are added to Janky.

Does it give you an id for the build with the 201 created?

On Fri, Jun 21, 2013 at 3:28 AM, Jose Luis Salas
notifications@github.comwrote:

Starting from Jenkins 1.519 returns HTTP/201 for successful created jobs
instead of a HTTP/302, so an error is raised and no build are added to
Janky.


Reply to this email directly or view it on GitHubhttps://github.com//issues/157
.

It queues the build in jenkins and when finishes it notifies back to janky and then campfire room. But the build it's marked as not created ( it's in the DB ) and then it's not shown in the janky dashboard.

This is the HTTP response in 1.518

HTTP/1.1 302 Found
Date: Fri, 21 Jun 2013 21:52:26 GMT
Content-Length: 0
Connection: keep-alive
Location: https://ci.wadus.com/job/wadus-platform-6429c2e35c09d4e4ffe25211004af196/
X-Powered-By: Servlet/2.5 (Winstone/0.9.10)

And this is the HTTP response in 1.519

HTTP/1.1 201 Created
Date: Fri, 21 Jun 2013 21:54:27 GMT
Content-Type: text/html;charset=UTF-8
Content-Length: 0
Connection: keep-alive
Location: https://ci.wadus.com/queue/item/1/
X-Powered-By: Servlet/2.5 (Winstone/0.9.10)
sr commented

🆒 thanks for reporting this. Should be an easy fix:

https://github.com/github/janky/blob/master/lib/janky/builder/http.rb#L23

Closing as #159 is merged upstream