glamod/glamod-nuim

Fix minutes in Observation ID [Subdaily CDM Lite]

Closed this issue · 6 comments

rjhd2 commented

Input files have off-hour ovservations in the QFF:

FRI0000LFRI|LES AJONCS|2021|04|01|21|30|46.7019|-1.3786|91.1|15.0|223||ICAOLFRI-8|9.0|223||ICAOLFRI-8|||||||||50.0|223||ICAOLFRI-8|3.6|223||ICAOLFRI-8

But output CDM lite files only have on-hour values (no later values than 21:00 for this station on 2021-04-01 in the psv file):

FRI0000LFRI-2-2021-04-01-21:00-106-12|0|2021-04-01 21:00:00+00|1|46.702|-1.379|10|106|320|50|12|0||1|FRI0000LFRI|LES AJONCS|0|1|223

Uncomment in setting of master df

sjnoone commented
sjnoone commented

I think this edit will fix this bug in the cdm_lite and observations code
existing df["Minute"]="00"
edit df["Minute"]=df["Minute"]

rjhd2 commented

Could we just remove the line df["Minute"]="00"? I'm not sure what your edit achieves?

sjnoone commented

Your right actually Minutes is already in the DF from teh QFf so we can just remove it

rjhd2 commented

Is the report_type also needing to be carried through (the GWS files have it but this code currently overwrites with 0)? If so, I'll amend the issue title and fix both in one go.

sjnoone commented