error during save

Question

error during save

Opened this issue 5 years ago · 18 comments

I receive this error during save

Error saving file:
Uncaught Error: Undefined AMF3 type encountered 'Boolean'
(https://cdn.mariani.life/projects/minerva/js/lib/AMF3.js:1)

To test this I created an export text file, copied it, and pasted it in as the json.
It loads fine, I guess. It looks fine.
But save results in the error shown

Answer 1 · 2019-12-18T20:27:26.000Z

can you attach a sample file ?

Answer 2 · 2019-12-18T20:34:37.000Z

Sample 01

{"urbanStock":9,"trophyArr":[],"playedBefore":true,"marketingBudget":0,"naam":"Silly","satisfaction":38.25,"popArr":[10,0,0,0],"cumCDS":84,"gridArray1":[[{"objDirection":"down","objRotation":"down","ID":"Gx19N8","objectType":"CD-Rack","owners":0,"objectLevel":2},{"objDirection":"down","objRotation":"right","ID":"Gx19N8","objectType":"CD-Rack","owners":2,"objectLevel":2},{"objDirection":"right","objRotation":"up","ID":"C8PzGQ","objectType":"Kassa","owners":0,"objectLevel":1}],[{"objDirection":"down","objRotation":"down","ID":"0FvKFr","objectType":"CD-Rack","owners":1,"objectLevel":2},{"objDirection":"right","objRotation":"right","ID":null,"objectType":null,"owners":0,"objectLevel":0},{"objDirection":"right","objRotation":"right","ID":null,"objectType":null,"owners":0,"objectLevel":0}],[{"objDirection":"right","objRotation":"right","ID":null,"objectType":null,"owners":0,"objectLevel":0},{"objDirection":"right","objRotation":"right","ID":null,"objectType":null,"owners":0,"objectLevel":0},{"objDirection":"right","objRotation":"right","ID":null,"objectType":null,"owners":0,"objectLevel":0}]],"indieStock":1,"danceStock":2,"gridArray2":[],"price":18.5,"gridArray3":[],"gridArray4":[],"kassaLevel1":1,"curDay":9,"kassaLevel2":1,"classicsStock":2,"kassaLevel3":1,"popStock":7,"resultsArray":[{"price":18.25,"customers":21,"sales":7,"netResults":127.75,"curDay":1,"karma":46.75},{"price":19.15,"customers":7,"sales":8,"netResults":153.20000000000002,"curDay":2,"karma":51},{"price":18.5,"customers":13,"sales":6,"netResults":111,"curDay":3,"karma":45.5},{"price":19,"customers":13,"sales":12,"netResults":228,"curDay":4,"karma":50},{"price":17.75,"customers":13,"sales":14,"netResults":248.55,"curDay":5,"karma":46},{"price":18.8,"customers":12,"sales":14,"netResults":263.45000000000005,"curDay":6,"karma":44.5},{"price":17.75,"customers":13,"sales":14,"netResults":248.55,"curDay":7,"karma":42.5},{"price":18.5,"customers":12,"sales":9,"netResults":166.5,"curDay":8,"karma":38.25}],"cumRes":1544,"currentArea":1,"moveArray":[],"areasBought":[],"money":33.7,"kassaLevel4":1,"hiFiArray":[],"neonArray":[]}

Answer 3 · 2019-12-18T20:35:01.000Z

Sample 02

Answer 4 · 2019-12-18T20:41:11.000Z

I could send you an SOL file as well if you like. I'm attempting to edit a save game for my high school students. (repairing a glitched game)

…

On Wed, Dec 18, 2019 at 1:27 PM gmariani ***@***.***> wrote: can you attach a sample file ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86?email_source=notifications&email_token=AGLNDTNJIZ7FJRSHA3WIGXLQZKBS5A5CNFSM4J4RA2MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHMONY#issuecomment-567199543>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLNDTK7IT6UO3YHY2LCYQTQZKBS5ANCNFSM4J4RA2MA> .

Answer 5 · 2019-12-18T21:01:28.000Z

Sure, the more information the better. Especially if i can reproduce the error quicker that always helps. I'm at work right now so i won't be able to get to it immediately.

Answer 6 · 2020-01-06T15:11:44.000Z

Heya, Any thoughts on this question?

…

-Terry

On Wed, Dec 18, 2019 at 2:01 PM gmariani ***@***.***> wrote: Sure, the more information the better. Especially if i can reproduce the error quicker that always helps. I'm at work right now so i won't be able to get to it immediately. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86?email_source=notifications&email_token=AGLNDTPOUI623YQECCKRSNDQZKFSTA5CNFSM4J4RA2MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHPJGA#issuecomment-567211160>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLNDTN5DA3XNGH2ICJI2CLQZKFSTANCNFSM4J4RA2MA> .

Answer 7 · 2020-01-06T15:37:50.000Z

I'm sorry, with work I forgot to look into this. I took a quick look now and it seems it does not like importing a boolean. It's not converting it properly recognizing it as an AS3 boolean. So when it goes to save it crashes out. I'll need to update it to resolve the issue. If you remove any properties with a true/false value it'll work if that is a workaround that will work for you in the meantime.

Answer 8 · 2020-01-06T18:19:04.000Z

HI, Actually, the format of the file 'should' be consistent. So, when I import the file, the boolean "is what it is". So when I edit and then export the file, it should be "what it was" when it was imported. If it originated as an AS3 boolean, it will need to be an AS3 boolean on export. Or, if it was some other 'type', it should be that same type on export. So, to review, to test this, I imported an SOL, and then, without edits, exported it. And got the error. Doesn't this imply that something is transforming inaccurately between import and export? For the record, I do not know what an AS3 boolean 'is'.

…

-Terry

On Mon, Jan 6, 2020 at 8:37 AM gmariani ***@***.***> wrote: I'm sorry, with work I forgot to look into this. I took a quick look now and it seems it does not like importing a boolean. It's not converting it properly recognizing it as an AS3 boolean. So when it goes to save it crashes out. I'll need to update it to resolve the issue. If you remove any properties with a true/false value it'll work if that is a workaround that will work for you in the meantime. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86?email_source=notifications&email_token=AGLNDTPNIRCFICKV2KLNM5DQ4NF47A5CNFSM4J4RA2MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFZ3MA#issuecomment-571186608>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLNDTN7PDC53ITFMV5CGNTQ4NF47ANCNFSM4J4RA2MA> .

Answer 9 · 2020-01-06T18:56:02.000Z

Sorry if i was a bit vague there, so let me explain. When you have a SOL file, it is in a binary format of AS3/AS2 data. AS3 is a strongly typed language, so a variable is a Boolean, String, Integer, etc. But when you export (not save) a SOL file from minerva, it converts it to JSON. JSON is not a strongly typed language and it makes it more difficult to guess what the original data type was. So when minerva imports the data back in, it makes some assumptions as to what the data type was originally. For example a "true" would come back as a string where as just true should be a boolean. In JSON they are both strings, there is no difference. That is what I meant by converting it to an AS3 boolean, it's the translation from JSON to AS3 that is tripping up.

When you say you "I imported an SOL", did you mean JSON or did you actually open a SOL file? What you put in this issue was JSON. If so, you are already converting JSON to AS3 and then exporting it back as JSON. If the end goal is just to edit the JSON, I would advise just to edit the JSON. minerva is not intended to be a JSON editor.

Answer 10 · 2020-01-06T19:43:38.000Z

Okay, My turn for clarity. We are using a Flash game for our business class. The game stores game data in an SOL file. I have a scenario file .SOL file. I have students play the scenario, so everyone is playing the same scenario. Normally, I can import an SOL file, edit it in Minerva, and resave with the change. For instance, I could take a game where a student has $500 and edit it to give them $2000 more dollars, and then use that new SOL file to restart the game. Occasionally, a game file be become corrupted somehow. So, I took a corrupted file, and imported it, saved it as text, found obvious differences/errors, corrected them, and attempted to export it to SOL again. That's when the error occurred. The only obvious bool, identified via minerva, is this (after SOL converted to txt via Minerva): "playedBefore":true, So, does the text true imply AS3? Whatever the case, why does minerva convert it to text, and then convert it back the same way? Or, how do I make it default correctly? I don't mean to occupy your time. And, I love solving these kinds of problems. Please don't prioritize me over anything.

…

-Terry

On Mon, Jan 6, 2020 at 11:56 AM gmariani ***@***.***> wrote: Sorry if i was a bit vague there, so let me explain. When you have a SOL file, it is in a binary format of AS3/AS2 data. AS3 is a strongly typed language, so a variable is a Boolean, String, Integer, etc. But when you export (not save) a SOL file from minerva, it converts it to JSON. JSON is not a strongly typed language and it makes it more difficult to guess what the original data type was. So when minerva imports the data back in, it makes some assumptions as to what the data type was originally. For example a "true" would come back as a string where as just true should be a boolean. In JSON they are both strings, there is no difference. That is what I meant by converting it to an AS3 boolean, it's the translation from JSON to AS3 that is tripping up. When you say you "I imported an SOL", did you mean JSON or did you actually open a SOL file? What you put in this issue was JSON. If so, you are already converting JSON to AS3 and then exporting it back as JSON. If the end goal is just to edit the JSON, I would advise just to edit the JSON. minerva is not intended to be a JSON editor. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86?email_source=notifications&email_token=AGLNDTPOMIFKOURYZ3BCQ5TQ4N5EFA5CNFSM4J4RA2MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIGM3JI#issuecomment-571264421>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLNDTLPY4GUTU7PK4IQRA3Q4N5EFANCNFSM4J4RA2MA> .

Answer 11 · 2020-04-05T23:31:35.000Z

Duplicate of #83

Answer 12 · 2020-04-05T23:32:09.000Z

I have this resolved in v4.3.3 and will be releasing it shortly

Answer 13 · 2020-04-13T20:37:06.000Z

I tried this today and got different results, but not better results. I can open an SOL, and save it as txt. I can edit the txt, with notepad. I can copy and paste the txt into minerva via 'import'. If I 'export', it saves as a txt. If I 'save', it creates a file without an extension. If I then add .sol, as the extension, the newly created file is not recognized as valid by the source program, which replaces it with a new file. Let me know if you want me to send the file, or, the text of the file to test with.

…

-Terry

On Sun, Apr 5, 2020 at 5:32 PM gmariani ***@***.***> wrote: I have this resolved in v4.3.3 and will be releasing it shortly — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLNDTLMO5ON4UX45HBD7A3RLEIIPANCNFSM4J4RA2MA> .

Answer 14 · 2020-04-15T00:18:48.000Z

any and all sample files is appreciated, whatever i need to replicate the issue so i can see what is going on. thanks

Answer 15 · 2020-04-28T19:09:00.000Z

Sorry for the delay. We've been very busy starting a new quarter (high school)under quarantine. I found time today to demonstrate the program, how I use it, the bug that appears, and my attempt to repair the bug using Minerva. My apologies for the length of the video. But I think it will add a ton of clarity to the issue. Cheers to you,

…

-Terry Mariani bug testing.zip <https://drive.google.com/file/d/1SYloJwbfJ4ac5XGesXU1u-oXlp5QmgmD/view?usp=drive_web>

On Wed, Dec 18, 2019 at 1:27 PM gmariani ***@***.***> wrote: can you attach a sample file ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86?email_source=notifications&email_token=AGLNDTNJIZ7FJRSHA3WIGXLQZKBS5A5CNFSM4J4RA2MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHHMONY#issuecomment-567199543>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLNDTK7IT6UO3YHY2LCYQTQZKBS5ANCNFSM4J4RA2MA> .

Answer 16 · 2020-04-28T19:10:19.000Z

Not sure how to send you a huge files. (video of bug report) I have it as a google drive zip, but not sure how to share with you.

…

-Terry

On Tue, Apr 14, 2020 at 6:19 PM gmariani ***@***.***> wrote: any and all sample files is appreciated, whatever i need to replicate the issue so i can see what is going on. thanks — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLNDTNUFCMXL6E4TRKHIJLRMT4PJANCNFSM4J4RA2MA> .

Answer 17 · 2020-05-11T02:06:17.000Z

you can send it to me via https://wetransfer.com/ or equivalen.

Answer 18 · 2022-03-17T13:00:15.000Z

If you're still able to send me the video (or equivalent) let me know. I tried testing what you did with a simple file and did not run into any issues so a sample of what you were testing with that broke would help.