goodby/csv

Custom fputcsv

oliverskawronek opened this issue · 1 comments

Thanks for this library!

I took a look into CsvObjectFile and saw that you are utilize the PHP's own fputcsv by writing into a temp stream and catch the written line.

It would be nice, if you could write your own fputcsv that would be more customizable. Some features that could be implemented with that are:

(I know, that you already have a filter mechanism. But the filter is feed with serialized line splitted by the spearator as strings, not with the raw data).

I concur, the standard fputcsv in php7 is not very flexible. I suggest to go to the RFC 4180 that is more specific.

  • What is missing is a customizable record separator (might be \r or \n or \r\n, or something completely different)
  • The default behavior of escaping an enclosure by repeating it is rather random, throwing an exception if no escape_char is supplied might actually be good for defensive programming.