google/caliban

Missing newlines in generated Dockerfile when using GCP credentials

eschnett opened this issue · 1 comments

I started setting up GCP credentials etc., and am now seeing this error with caliban shell:

$ caliban shell --nogpu --docker_run_args '--volume /Users/eschnett/caliban-simulations:/caliban-simulations'
I0802 13:31:15.145786 4626697664 build.py:645] Running command: docker build --rm -f- /Users/eschnett/src/CarpetX

[...]

Step 8/8 : COPY --chown=501:20 .caliban_adc_creds.json /home/eschnett/.config/gcloud/application_default_credentials.jsonCOPY --chown=501:20 cloud_sql_proxy.py /.resources
COPY failed: stat /var/lib/docker/tmp/docker-builder529025309/home/eschnett/.config/gcloud/application_default_credentials.jsonCOPY: no such file or directory
E0802 13:31:33.397300 4626697664 main.py:165] Docker failed with error code 1.
E0802 13:31:33.397594 4626697664 main.py:166] Original command: docker build --rm -f- /Users/eschnett/src/CarpetX

The Dockerfile is missing a newline, so that two successive COPY statements run together.

@eschnett this should be fixed!