Pod 1.1.4 - "GTMOAuth2ErrorTokenUnavailable" Naming error

Question

Pod 1.1.4 - "GTMOAuth2ErrorTokenUnavailable" Naming error

mikezucc opened this issue 8 years ago · 10 comments

for pod 1.1.4, GTMOAuth2ErrorTokenUnavailable is used instead of kGTMOAuth2ErrorTokenUnavailable. Anyone else get this build error? Something seems off with the pod, because if I manually resolve this a linker error shows up later on for a misnamed selector

Answer 1 · 2016-12-06T18:22:11.000Z

The constant doesn't have a k on the front: https://github.com/google/gtm-oauth2/blob/master/Source/GTMOAuth2Authentication.h#L102.

The one with the k is a #define - https://github.com/google/gtm-oauth2/blob/master/Source/GTMOAuth2Authentication.h#L110

Answer 2 · 2016-12-06T18:28:30.000Z

The build fails in this function:

+ (BOOL)saveParamsToKeychainForName:(NSString *)keychainItemName
                      accessibility:(CFTypeRef)accessibility
                     authentication:(GTMOAuth2Authentication *)auth
                              error:(NSError **)error
  [self removeAuthFromKeychainForName:keychainItemName];
  // don't save unless we have a token that can really authorize requests
  if (![auth canAuthorize]) {
    if (error) {
      *error = [NSError errorWithDomain:kGTMOAuth2ErrorDomain
                                   code:GTMOAuth2ErrorTokenUnavailable
                               userInfo:nil];
    }
    return NO;
  }

  if (accessibility == NULL) {
    accessibility = kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly;
  }

  // make a response string containing the values we want to save
  NSString *password = [auth persistenceResponseString];
  GTMOAuth2Keychain *keychain = [GTMOAuth2Keychain defaultKeychain];
  return [keychain setPassword:password
                    forService:keychainItemName
                 accessibility:accessibility
                       account:kGTMOAuth2AccountName
                         error:error];
}

Exact error: Use of undeclared identifier GTMOAuth2ErrorTokenUnavailable

Answer 3 · 2016-12-06T18:29:44.000Z

Also, my version of that header is

enum {
  // Error code indicating that the window was prematurely closed
  kGTMOAuth2ErrorWindowClosed          = -1000,
  kGTMOAuth2ErrorAuthorizationFailed   = -1001,
  kGTMOAuth2ErrorTokenExpired          = -1002,
  kGTMOAuth2ErrorTokenUnavailable      = -1003,
  kGTMOAuth2ErrorUnauthorizableRequest = -1004
};

Answer 4 · 2016-12-06T18:30:59.000Z

Ah it seems that a pod is using GTM 1.0, not 1.1.4. I'm guessing the version of the header is 1.0

Answer 5 · 2016-12-06T18:31:44.000Z

https://cocoapods.org/pods/GoogleSignIn

Answer 6 · 2016-12-06T18:33:14.000Z

Sounds like something is causing a mix of versions then? You'll probably want to reach out to them about the making sure they can use 1.1.x also.

Answer 7 · 2016-12-06T18:38:10.000Z

Yep I'll send an email to Google. thanks for quick response 👍

Answer 8 · 2016-12-06T18:38:27.000Z

You can close this as not an issue

Answer 9 · 2016-12-06T18:39:52.000Z

Actually, are they shipping copies of these headers? Maybe that's where the mixup comes, you get one dep on this pod which is 1.1.x, and they ship a copy of the older headers and the header search path decides what gets found.

Answer 10 · 2016-12-06T18:53:13.000Z

Actually, I was doubly wrong, we had a lingering dependency from the original google plus ios sdk days where they shipped with copies of the old frameworks. false alarm :]