base/buffer.h: Type qualifiers ignored on function return type

[CodeArno]

Hi,

Compiling Riegeli in our project setup creates the following GCC warning/error:
riegeli/base/buffer.h:52:3: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

The reason is that the first const in the line has no effect, since it returns by value:
const size_t size() const { return size_; }

It would be great if you could just merge it - I've created #3, but Googlebot doesn't like me. :)

Thanks,
Arno

[QrczakMK]

Thank you! This is now fixed: 29d474f

…

On Fri, 9 Aug 2019 at 15:34, Arno Fleck ***@***.***> wrote: Hi, Compiling Riegeli in our project setup creates the following GCC warning/error: riegeli/base/buffer.h:52:3: type qualifiers ignored on function return type [-Werror=ignored-qualifiers] The reason is that the first const in the line has no effect, since it returns by value: const size_t size() const { return size_; } It would be great if you could just merge it - I've created #3 <#3>, but Googlebot doesn't like me. :) Thanks, Arno — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=ACAUJJAHUCSYS6DKXZM7QUTQDVW6HA5CNFSM4IKUCLA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HEMZZPA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACAUJJA3CDWYI3UV5FD5EX3QDVW6HANCNFSM4IKUCLAQ> .

-- Marcin Kowalczyk