Failed to cleanly publish 109
arv opened this issue · 6 comments
npm run just-published failed to tag and update the github repo because the tests now fail.
The problem is that our commonjs output does not handle circular dependencies and that makes src/runtime/modules/typeof.js not work.
I manually fixed this by disabling --symbols when building dist/commonjs. I need to think close about how to solve this in a better way.
Hmmm. The NodeJS v0.10 builder fails one test now.
@johnjbarton I think I need to revert this. I don't know how to get this fixed in the short term.
revert "this"? The runtime import PR? I guess its only our own circular deps that are an issue, not users?
I figured out a simple solution. I need to recompile symbol.js without the --symbol option. The self dependency on typeof is causing the issue.
The idea in the above comment seems to work but there are other issues. test/register-cjs-test-wrapper.js requires ../src/node/api.js which requires traceur.js which polyfills symbols which leads to multiple versions of Symbol. I'm going to make test/register-cjs-test-wrapper.js depend on dist/commonjs/Compiler.js instead but that exposed another issue. I'll work through them one by one.