Implement PLAY and SOUND

Question

Implement PLAY and SOUND

flagxor opened this issue 7 years ago · 7 comments

We should implement PLAY + SOUND.

Answer 1 · 2018-09-24T04:28:41.000Z

Sounds like thomasmcneill has this implement here:
https://github.com/thomasmcneill/wwwbasic/commits?author=thomasmcneill

Answer 2 · 2018-09-24T04:43:13.000Z

It looks like your changes are actually on master of your branch, which sound be mergeable.
It should work to create another pull request against master.
You want it to look like this:
https://pasteboard.co/HFjPsKk.png

That should be the default if you click 'pull request' under the clone and download button from here:
https://github.com/thomasmcneill/wwwbasic

Answer 3 · 2018-09-24T11:47:06.000Z

I can cut and paste them anywhere. It's just a few functions and a few vars up top. Whatever is easier for you.

…

On Mon, Sep 24, 2018 at 12:43 AM Brad Nelson ***@***.***> wrote: It looks like your changes are actually on master of your branch, which sound be mergeable. It should work to create another pull request against master. You want it to look like this: https://pasteboard.co/HFjPsKk.png That should be the default if you click 'pull request' under the clone and download button from here: https://github.com/thomasmcneill/wwwbasic — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOPhs2_Vq-EB5Pm66yWarIQgf0SHW-1wks5ueGLjgaJpZM4W2DJ7> .

Answer 4 · 2018-09-25T23:53:47.000Z

Hi Thomas,

Looking at your branch more closely, there's a few licensing issues we'd need to sort through before merge (to keep the lawyercats at bay :-). See below.
I'll happy to rework things as you've done the hard part of getting it running!
Unless you'd rather?
I've also figured out how to create a PR with your master changes and then override the CLA bot.

For the note frequencies, the license/copyright notice on the page seems to forbid copying (as opposed to linking): https://pages.mtu.edu/~suits/PofMCopyRight.html
- Calculating the note frequencies can just be done with Math.pow(2, n/12) * 110 or some such, so we can likely substitute a formula.
For the PLAY docs, they fall under CC-3.0, https://creativecommons.org/licenses/by-sa/3.0/, that carries different limits than Apache, so it might be better to link to that rather than inline.
The sample with PLAY has something similar. We could put it in third_party, but that seems tedious. Alternatively, I'm sure I can come up with an unencumbered jingle for the example.

I'll likely get cycles to do this closer to the weekend.

Cheers

-BradN

Answer 5 · 2018-09-26T11:57:44.000Z

I posted the documentation in there just so I had it while I was working on it. The frequencies are pretty commonly known. Multiple charts from multiple sites had the same information. Wikipedia has the chart. https://en.wikipedia.org/wiki/Piano_key_frequencies I'll remove the inline notes for myself. And I actually have somes stuff I wrote years ago. There is always Mary had a Little lamb. Quick search shows it is public domain.

…

On Tue, Sep 25, 2018 at 7:53 PM Brad Nelson ***@***.***> wrote: Hi Thomas, Looking at your branch more closely, there's a few licensing issues we'd need to sort through before merge (to keep the lawyercats at bay :-). See below. I'll happy to rework things as you've done the hard part of getting it running! Unless you'd rather? I've also figured out how to create a PR with your master changes and then override the CLA bot. - For the note frequencies, the license/copyright notice on the page seems to forbid copying (as opposed to linking): https://pages.mtu.edu/~suits/PofMCopyRight.html - Calculating the note frequencies can just be done with Math.pow(2, n/12) * 110 or some such, so we can likely substitute a formula. - For the PLAY docs, they fall under CC-3.0, https://creativecommons.org/licenses/by-sa/3.0/, that carries different limits than Apache, so it might be better to link to that rather than inline. - The sample with PLAY has something similar. We could put it in third_party, but that seems tedious. Alternatively, I'm sure I can come up with an unencumbered jingle for the example. I'll likely get cycles to do this closer to the weekend. Cheers -BradN — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOPhs9YUlllvjU9sga3npTdrD1OMtrlHks5uesIMgaJpZM4W2DJ7> .

Answer 6 · 2018-12-17T22:30:04.000Z

Looking forward to sound implementation as well. Hope you work it out.

Example program (for now):
http://aleatoryrecords.com/

Answer 7 · 2018-12-18T01:26:36.000Z

I'll be able to update it soon. I have been swamped. I'll get out all the documentation I put in it that's from other sources and go with a log table for frequencies or something more open source friendly.

…

On Mon, Dec 17, 2018 at 5:30 PM Page Telegram ***@***.***> wrote: Looking forward to sound implementation as well. Hope you work it out. Example program (for now): http://aleatoryrecords.com/ — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOPhs9eSfTveTpsPjsGZRCXg0iWYTWgAks5u6BrtgaJpZM4W2DJ7> .