Add test for calling `.{write,end}(buffer, callback)`
Closed this issue · 1 comments
gr2m commented
Did you test when calling
write
,end
et al. with a chunk and a callback
That's a minor thing, but given
readable.setEncoding
, the recorder is converting strings back to buffers presuming UTF-8(?).
My thinking here was to normalize the requestBodyChunks
passed to the the record
event listeners. I'm not worried about the performance overhead as this is a dev tool. Do you see any other problem? I will default encoding to utf-8
as part of #17
github-actions commented
🎉 This issue has been resolved in version 1.1.4 🎉
The release is available on:
Your semantic-release bot 📦🚀