CharStackValue/charset
Closed this issue · 2 comments
mikejsavage commented
we need to decide on a charset and we need to enforce it in charstackvalue. also stuff like this.charCode = intToCharCode((int)ch - 65); is not advisable because then you just have to undo that when you print it.
greglo commented
Well at the moment is it capital letters only (which I think is a sensible limitation, if they are basically going to be used for encryption). What specifically are you suggesting? Otherwise you are welcome to commit it, as long as the current arithmetic laws stay valid (Z + B = A)
mikejsavage commented
it's not making a scene if you pass it anything invalid atm it just not-obviously mangles it into something that is which needs improving and i'm happy to work on that