Fix test case for approximate tree search

Question

Fix test case for approximate tree search

Closed this issue 4 years ago · 6 comments

kanodiaayush commented 4 years ago

" tree search with approximate splitting works as expected ": fix this test case as it fails sometimes.

Answer 1 · 2020-03-07T16:36:49.000Z

Can you say which test fails?

Answer 2 · 2020-03-10T18:28:34.000Z

The test as cited above ("tree search with approximate splitting works as expected")..

Answer 3 · 2020-03-10T18:37:12.000Z

That test has 8 checks, are you saying all 8 checks always fail?

Answer 4 · 2020-03-10T18:41:00.000Z

oh; within that.

expect_true(reward.skip2 > 1.5 * reward.colmax)

This fails probabilistically. It passed with my current set of changes which are only aesthetically different from the last. Maybe we could hardcode the seed so that it does not fail probabilistically (at least on machines with Linux?).

Does this show up as 8 tests or 1 test in the testing console (for my information)?

Answer 5 · 2020-03-10T18:52:03.000Z

It should show up as failed: "tree search with approximate splitting works as expected" then show which checks within that failed.

How about just changing it to expect_true(reward.skip2 > reward.colmax) which is just a loose check that it is not doing anything terrible (the behavior tested should be robust enough that it holds regardless of seed)

Answer 6 · 2020-03-10T19:38:55.000Z

We can do that. I'll make this fix and push a PR. Ayush Kanodia, PhD Student, Stanford Computer Science

…

On Tue, Mar 10, 2020 at 11:52 AM Erik Sverdrup ***@***.***> wrote: It should show up as failed: "tree search with approximate splitting works as expected" then show which checks within that failed. How about just changing it to expect_true(reward.skip2 > reward.colmax) which is just a loose check that it is not doing anything terrible (the behavior tested should be robust enough that it holds regardless of seed) — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#12?email_source=notifications&email_token=AAM4G4PRBOTK7R7ES7GZ52DRG2D6DA5CNFSM4LDNYLKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOMV77A#issuecomment-597254140>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM4G4LY2NMNTADML7KOD5DRG2D6DANCNFSM4LDNYLKA> .