gumyr/build123d

Topology Constructors: Shell

Closed this issue · 0 comments

gumyr commented

The topology constructors are missing for the derived classes of Shape and therefore appear to have the same superset of parameters for all of them even though that isn't true. For example, a Shell can have no children, a parameter restricted to Compound. In addition, class methods are required to create basic objects - for example Shell.make_shell(faces).

These classes should get their own constructors and be able to accept class specific objects for the creation of the basic object. For Wire the following two signatures should be available:

  1. obj: TopoDS_Shape/TopoDS_Shell
  2. faces: Iterable[Face]

(all of these would also have the label, color and parent parameters)

The Shell.make_shell method will be deprecated and removed in the v1.0.0 release.