dynamic change columns, item will overlap

Question

dynamic change columns, item will overlap

Closed this issue 5 months ago · 12 comments

UTing1119 commented a year ago

Expected Behavior

dynamic change columns and it should calculate new item's position correctly.

Current Behavior

item will overlap

Steps to Reproduce

dynamic change columns
the item which is overflow will change to position 1 and overlap the first item

I will try to fix it, plz let me know if the overflow item is static, how would you want it to behave

Answer 1 · 2023-08-08T07:44:54.000Z

Hi there, I think this is a side effect after we fixed your previous bug. Rgds Geirr

…

On Tue, 8 Aug 2023 at 03:45, UTing1119 ***@***.***> wrote: Expected Behavior dynamic change columns and it should calculate new item's position correctly. Current Behavior item will overlap Steps to Reproduce 1. dynamic change columns 2. the item which is overflow will change to position 1 and overlap the first item [image: wcvb9-ws07f] <https://user-images.githubusercontent.com/74576629/258960891-b1388ff2-55c3-424e-970b-71ce02b715f6.gif> I will try to fix it, plz let me know if the overflow item is static, how would you want it to behave — Reply to this email directly, view it on GitHub <#12>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRBD4ACHUC27OQYITX2PQ3XUGK3DANCNFSM6AAAAAA3HYBRX4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Answer 2 · 2023-09-07T07:06:29.000Z

Hi, @UTing1119 did you manage to make a fix for this ?

Answer 3 · 2023-09-08T02:44:33.000Z

yes, I was tryna find the reason why the resize event will be triggered when col number is set by user.(edit: yes it needs to be resized, but I'm trying to fix the calculate function)

do you have any plans to refactor?

Answer 4 · 2023-09-08T03:11:55.000Z

Hi @UTing1119
I am doing some work on the component right now, and will look into this issue to. Just wanted to check up on your progress on this issue.

Answer 5 · 2023-09-19T09:30:20.000Z

@UTing1119 may I ask what you are using the component for ?

Btw I just released version 1.2.2

Regards

Geirr

Answer 6 · 2023-09-20T03:10:39.000Z

@gwinnem if you're referring to dragging items, that's because I'm tryna set up a template item that will be added to the GridLayout correctly.
and maybe provide slots for users to customize its appearance.

but unfortunately I have no time to fix it or refactor it.
if any idea, plz let me know

Answer 7 · 2023-12-29T08:09:30.000Z

still not work in version 1.2.2/1.2.4/1.2.5

Answer 8 · 2023-12-30T13:50:21.000Z

@UTing1119
I'll try to fix this asap.
Currently working on the Resize enhancement issue
But will pause this and start working on this issue.

Answer 9 · 2024-01-02T06:37:34.000Z

Hi @UTing1119
If im correct, it is alway the top left GridItem which have this issue ?

Answer 10 · 2024-01-02T07:02:41.000Z

I think it's more like the item overflows right side of the layout.

I guess it's because in src/core/helpers/responsiveUtils.ts, both moveToCorrectPlace and correctBounds function only consider about whether to collide with static items or not.

Answer 11 · 2024-01-02T13:44:03.000Z

I think it's more like the item overflows right side of the layout.

I guess it's because in src/core/helpers/responsiveUtils.ts, both moveToCorrectPlace and correctBounds function only consider about whether to collide with static items or not.

It is strange the behavior, but with multiple statics the result is a lot of overflows when dynamically changes the max col value.

I am looking into it now and will release a new version asap.

Answer 12 · 2024-02-02T15:51:07.000Z

Should be fixed in 1.2.9