h5bp/Effeckt.css

Nested mixin error

SteveBenner opened this issue · 1 comments

Hi, just being tentative about making a pull request because A) I don't know what changes are planned for the next version of SASS too well and B) this is really a tiny issue.

On compile I receive this error:
error scss/effeckt/effeckt.scss (Line 694 of scss/effeckt/modules/off-screen-nav.scss: Mixins may not be defined within control directives or other mixins.)

The offending code should be replaced with:

@mixin minimize-reveal-list-items-fade {
  transform: translateX(0);
  opacity: 1;
}

@mixin minimize-reveal-list-items-shown {
    @include minimize-reveal-list-items-fade;
    h4 {
        @include minimize-reveal-list-items-fade();
        //fade in header first.
        transition-delay: $effeckt-off-screen-navigation-transition-duration;
    }
    @for $i from 1 through 50 {
        li:nth-child(#{$i}) {
            @include minimize-reveal-list-items-fade();
            //wait until the header has finished
            transition-delay: $effeckt-off-screen-navigation-transition-duration * 2 + $effeckt-off-screen-navigation-transition-duration * $i * 0.25;
        }
    }
}

... correct?

I don't know, maybe. I changed the way you said. if not, I'll remove it.