haishanh/night-owl.vim

Unable to get theme working

Closed this issue · 4 comments

robertcoopercode commented

Hello,

I'm trying to get this theme to work in iTerm2, but the colors seem to be off:

image

Here's my .vimrc:

" Specifying the plugin folder for vim-plug
call plug#begin('~/.vim/plugged')

" JS Syntax highlighting
Plug 'pangloss/vim-javascript'
" JSX Syntax highlighting
Plug 'mxw/vim-jsx'
" TypeScript Syntax highlighting
Plug 'leafgarland/typescript-vim'
" Night Owl Theme
Plug 'haishanh/night-owl.vim'

" Initialize the vim-plug plugin system
call plug#end()

" enable 24bit true color
if (has("termguicolors"))
 set termguicolors
endif

" Enable theme
syntax on
colorscheme night-owl

Any ideas? Thanks!

haishanh commented

@robertcoopercode Hi there,

I've no idea what's wrong. It seems comments are not rendered as expected.

What is your iTerm2 version?

Could you check if your terminal support italic font with:

echo "\033[3mhello\033[0m"
robertcoopercode commented

Iterm2 v3.2.4 and yes, the terminal supports italics:

image.

I think something must be wrong with the my .zshrc config or my iTerm2 settings. I've tried using some other themes and some render correctly while others don't.

Example:

Molokai - Renders correctly ✅

image

Palenight - Colors are a bit off ❌

image

I'll close this issue as it's not specific to this theme, but if you have any other ideas of what's causing the issue, let me know! Thanks :)

haishanh commented

@robertcoopercode You may try run these commands in vim:

:hi Comment guifg=#637777 ctermfg=243 guibg=#011627 ctermbg=233 gui=italic cterm=italic
:hi jsComment guifg=#637777 ctermfg=243 guibg=#011627 ctermbg=233 gui=italic cterm=italic
oshimayoan commented

Howdy! Sorry for bringing up this issue again.

I can't get the theme working too in .tsx file but it works fine with .js file.

I've tried:

:hi jsImport guifg=#990000

but it only works on .js file too.

I'm using these plugins:

Plug 'pangloss/vim-javascript'
Plug 'jelera/vim-javascript-syntax'
Plug 'leafgarland/typescript-vim'
Plug 'peitalin/vim-jsx-typescript'

Here's the snippet from .tsx file:
image

and here's the snippet from .js file:
image

  • 👍1