Incorrect big.mark in the df.format

[jkomelj]

In my country, the default is dec.mark="," and big.mark=".", but the function format.df does not work correct, if called with these parameters. Doing some minor changes in it, e.g. dec.mark=getOption("OutDec"), I was able to fix it for my needs. But whatever I try, big.mark in the result is always a comma instead of dot. However, formatting the data frame column by column with other functions, I can bypass the problem, but it would be nice, if format.df could be used. I mainly use the latex function. It is great. Thank you.

Janez Komelj, Slovenia

An example:

require(Hmisc)
A <- data.frame(a=c(123456.12345,654321.987654),b=c(654321.987654,123456.12345))
B <- format.df(A,cdec=c(2,3),dec.mark=",",big.mark=".")

[harrelfe]

I changed format.df to use OutDec when cdot is not specified. This should fix it. Thanks.

[jkomelj]

Thank you! From: Frank Harrell ***@***.***> Sent: Sunday, August 29, 2021 6:52 PM To: harrelfe/Hmisc ***@***.***> Cc: jkomelj ***@***.***>; Author ***@***.***> Subject: Re: [harrelfe/Hmisc] Incorrect big.mark in the df.format (#142) I changed format.df to use OutDec when cdot is not specified. This should fix it. Thanks. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#142 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD5KJR3WND4BJJXLDCNCFDLT7JQRNANCNFSM45JLISNQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .

[jkomelj]

The function format.df still changes the optional parameter big.mark="." in decimal.mark. It is changed by the formt function. formt <- function(x, decimal.mark='.', nsmall=0, scientific=c(-4,4), digits=NULL, na.blank=FALSE, ...) { y <- format(x, nsmall=nsmall, decimal.mark=decimal.mark, digits=digits, ...) ###??? Is the replacement below necessary? If format.df is called with the ###??? optional parameter big.mark=".", it is not correct. In my case, ###??? the results are correct, if the line below is excluded. ###??? if(decimal.mark != '.') y <- gsub('\\.', decimal.mark, y) if(na.blank) y <- ifelse(is.na(x), '', y) y }