Clean up public APIs that may not need to be public or exist at all
xyzsam opened this issue · 0 comments
xyzsam commented
In the course of updating docs, I've come across a number of public APIs that should either be removed or hidden. Listing them here to keep track and fix if necessary.
- We have an
allocateStorage(dataType)
method which dispatches to an underlying templatedallocateStorage<T>
method. Is there any reason why the templated method needs to be public too? TiledTensor
has a ctor with no shape. Why?- Should
_useRawTensor
be part of the public API forTiledTensor
? It's an optimization that is rarely useful and difficult for the user to understand. - Do we still need
copyTensorData
, which copies a linear region of memory, if we already havecopyTensorRegion
? generateTiledTensor
requires anOperator
param, but we only use the name field. We should just pass the name directly.- There are two overloads on
generateTiledTensorAndCopyData
- I believe we only need the variadic templated one. REGISTER_SPECIAL_OP
is a macro used for the ref backend operators, but not for SMV. We may want to get rid of this since a user who comes across this may assume this is all that is required to add his/her operator to SMAUG.MAYBE_UNUSED
appears...unused.ConvolutionOp
implements an emptyrun
method. Should this be pure virtual?