hashobject/perun

Support Clojure 1.9+

Closed this issue · 9 comments

jaidetree commented

Perun cannot run entirely in Clojure 1.9+. This is due to a dependency on sitemap with a ns form that doesn't conform to the updated spec. The fix for sitemap was merged into master but there are a few steps involved before it can be updated in perun.

  • Patch sitemap to pass Clojure 1.9+ validation
  • Merged sitemap patch into master
  • Release new version of sitemap
  • Update sitemap dependency in perun deps. (waiting for #224)
  • Release new version of perun
allentiak commented
jaidetree commented

What needs to be done to release the next version of sitemap? No rush or anything 😄, just want to understand the status of that project in relation to perun.

podviaznikov commented

released sitemap 0.4.0.
let me know if anything is needed there https://clojars.org/sitemap

allentiak commented

@eccentric-j
Once closed, #224 will take care of the third item.
I added a fourth item to the list for the released of an updated perun afterwards.

jaidetree commented

Great, thanks Podviaznikov. Added a note in the code review on #224 to bump sitemap to 0.4.0.

allentiak commented

@eccentric-j #224 has been merged

jaidetree commented

@allentiak Great, thanks.

@podviaznikov @allentiak What's next to be able to release the next version of perun?

allentiak commented
allentiak commented

I have tested perun with Clojure 1.10.1, and it works fine. (I'm closing this.)

(The only thing left to do would be the release, but I think we should first discuss what we would like to see there.)