Add HasCallStack to partial functions

Question

Add HasCallStack to partial functions

dwincort opened this issue 7 years ago · 5 comments

Can we add HasCallStack to the constraints of partial functions like Map.!? I'd be happy to put together a PR if it's a change that would get accepted.

Answer 1 · 2018-01-11T17:43:57.000Z

Yes, please! I was already thinking about doing that. But please show benchmark results to make sure the performance impact is tolerable.

…

On Jan 11, 2018 12:37 PM, "Daniel Winograd-Cort" ***@***.***> wrote: Can we add HasCallStack to the constraints of partial functions like Map.!? I'd be happy to put together a PR if it's a change that would get accepted. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#489>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABzi_XyCCjFQHVVCFlk7idclZNrHCL83ks5tJkbNgaJpZM4RbMQ8> .

Answer 2 · 2020-07-19T12:49:10.000Z

Related: haskell-unordered-containers/unordered-containers#252

Answer 3 · 2020-07-19T13:33:47.000Z

Since the analogous work on unordered-containers was very warmly received, I'd love to see progress on this issue.

AFAICT not all changes in #493 are problematic. I think it might be a good first step to extract those into a separate PR that can be merged quickly.

(CC @bollu)

Answer 4 · 2020-08-02T18:56:24.000Z

Oh wow, I totally forgot about this. The project I was working on ended up finding a different way to track errors, and this went to the bottom of my priority list.

I don't have the bandwidth right now to work on this, so if someone else wants to take over, that would be great. Otherwise, I may be able to find some time in a few weeks. I'll make a reminder for myself.

Answer 5 · 2020-08-17T17:56:29.000Z

For reference: Similar plans for base are discussed in https://gitlab.haskell.org/ghc/ghc/-/issues/17040.