hedefalk/atom-vue

Request to up to date

zhaolinlau opened this issue · 4 comments

zhaolinlau commented

May i request to up to date based on the latest vue syntax?

https://github.com/vuejs/language-tools/tree/master/extensions/vscode/syntaxes

confused-Techie commented

This isn't a bad idea at all. Since the TextMate grammar this package is based off of was last updated 9 years ago, and obviously with the one you linked being last updated a month ago does seem a whole lot better.

I will mention though, as this is a TextMate grammar with unwieldy Regex that I had no part in writing at all, I'll very likely aim to fully replace the existing Regex with the new stuff from this package, so this may cause some big differences, but hopefully those are only good ones.

If I were able to make a PR would you be willing to test the changes?

zhaolinlau commented

This isn't a bad idea at all. Since the TextMate grammar this package is based off of was last updated 9 years ago, and obviously with the one you linked being last updated a month ago does seem a whole lot better.

I will mention though, as this is a TextMate grammar with unwieldy Regex that I had no part in writing at all, I'll very likely aim to fully replace the existing Regex with the new stuff from this package, so this may cause some big differences, but hopefully those are only good ones.

If I were able to make a PR would you be willing to test the changes?

sure

  • 🎉1