henrytao-me/smooth-app-bar-layout

deprecated after 26.0.0?

kassim opened this issue · 9 comments

kassim commented

I just switched to the support library 26.0.0 (which was causing the appbar from this library to misbehave pretty badly) and after switching out the SmoothAppBarLayout component for the official AppBarLayout, the intended "smoothness" previously provided from this library was there

I could be mistaken, but it seems like the error of the support library that this project was intended to fix, may indeed now be fixed

henrytao-me commented

Thanks for your report. I will check it later. But if it works as you mentioned, it is awesome. We are all waiting for the fix for a long long time.

henrytao-me commented

Hi @kassim,
I confirm that the issue this library intending to fix is fixed in support library 26.0.0. Bravo support library team.

  • 👍1
kassim commented

bravo to you, creating a working implementation that Google couldn't, at least up until now

thanks for your great work

  • 👍1
roman-ku commented

@henrytao-me Can you add a note to the github page? That it's deprecated because the issue has been finally addressed by the support library.

Btw thanks for the great library! 👍

henrytao-me commented

@roman-ku I added this to README already. [DEPRECATED] Use support design 26.0.0 or above instead. Even the fix isn't documented but it is there. I have tested it.

  • 👍1
roman-ku commented

I wasn't sure why the library was deprecated, adding a little something about it being fixed wouldn't hurt.

henrytao-me commented

@roman-ku I updated the README to make it more clear. All the best.

  • 👍1
roman-ku commented

Thanks!