hicsail/constellation-js

one-or-more (zero-or-more atom) is wrong

Closed this issue · 4 comments

I fixed the visual for this in terms of how it is represented in stateGraph. Can't confirm if this is the desired graph but at least there isn't a phantom node pointing to the epsilon node anymore:
Screen Shot 2019-07-24 at 4 18 08 PM

I think one-or-more(zero-or-more) just means zero-or-more? So if we wanted to make the condensed visualization, there just shouldn't be a phantom edge. Regardless, I don't want to bandage the bug because if the underlying graph is wrong then the SBOL will be wrong

@vidyaap @xin-cao can we close this?

this is fixed by the simplification rules