Control + S shortcut is not passed to Qt Creator in non-insertion mode

Question

Control + S shortcut is not passed to Qt Creator in non-insertion mode

Opened this issue 10 years ago · 23 comments

Control + S shortcut is not passed to Qt Creator in non-insertion mode under Linux.
In Mac, if I press Command + S and file is not changed, fakevim behaves like only key 's' is pressed. It deletes the character under cursor and goes into insertion mode. If there is file change unsaved, it will save the file.

Answer 1 · 2014-02-16T10:08:35.000Z

If I press Ctrl+S in FakeVim, file is not saved but nothing happens -- i.e. s command is not triggered either.

Answer 2 · 2014-02-16T14:00:00.000Z

Did you test it under Linux or Mac? If it is Linux, nothing happens. In Mac, fakevim interprets Command + s (not ctrl + s) as 's' command.

Answer 3 · 2014-02-16T14:10:12.000Z

Yup, I've tested it under Linux. It seems that it checks Ctrl but not Command key. Also I wonder why it's not treated as shortcut.

Answer 4 · 2014-02-16T20:28:21.000Z

Patches here and here though they need a bit more testing.

Answer 5 · 2014-02-16T21:06:37.000Z

After I updated the fakevimhandler.cpp file to this version https://codereview.qt-project.org/#patch,sidebyside,78305,2,src/plugins/fakevim/fakevimhandler.cpp. The problem became worse in Mac. Some shortcuts, like EasyMotion shortcut <Ctrl+;> that previously can be catched in normal mode now can not be catched by EasyMotion.

Answer 6 · 2014-02-16T21:13:39.000Z

You'll have to use both patches in that order for this to work.

Answer 7 · 2014-02-16T21:17:14.000Z

Doesn't the second patch already contain the changes from the first patch? I downloaded the second patch, I saw the changes in the first patch is already in the second patch.

Answer 8 · 2014-02-16T21:21:51.000Z

If you downloaded the zip file, then the changes from both patches should be there.

Answer 9 · 2014-02-16T21:22:51.000Z

That is what I did

Answer 10 · 2014-02-17T06:37:05.000Z

Was at least the "<C-S> treated as s" issue fixes with the previous patch?

Answer 11 · 2014-02-17T09:39:44.000Z

The reason why shortcut <C-;> for EasyMotion plugin is "eaten" by FakeVim is that the shortcut generate text ; which can be handled by FakeVim.

This really needs to be solved because otherwise you won't be able to differentiate between <C-S-X> and <S-X>.

Answer 12 · 2014-02-17T14:27:38.000Z

after the patch the problem is even worse in Mac. Even if there is unsaved
change, fakevim always interprets cmd + s as s commad. before the patch, it
saves the file if there is unsaved change.
On Feb 17, 2014 4:39 AM, "Lukas Holecek" notifications@github.com wrote:

The reason why shortcut <C-;> for EasyMotion plugin is "eaten" by FakeVim
is that the shortcut generate text ; which can be handled by FakeVim.

This really needs to be solved because otherwise you won't be able to
differentiate between and .

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-35241393
.

Answer 13 · 2014-02-17T20:11:42.000Z

Here is fix for <C-S> and s (and others).

If you can, please try mapping some non-US keys -- I've tested few non-latin characters which worked but I expect there to be some exceptions.

Answer 14 · 2014-02-17T20:21:19.000Z

I just tested it in Mac, the problem still exists. If there is unsaved change, fakevim saves the file. If there is no change in the file, fakevim interprets cmd + s as s command.

Answer 15 · 2014-02-17T20:31:50.000Z

You could uncomment this line and remove this one (sorry, long time nobody has used it) and post the standard output after <C-S> key press.

Answer 16 · 2014-02-17T20:40:36.000Z

The following output is from the case when there is unsaved change, and I press cmd +s
SHORTCUT OVERRIDE 16777249 PASSING: false
NO SHORTCUT OVERRIDE 16777249
SHORTCUT OVERRIDE 16777249 PASSING: false
NO SHORTCUT OVERRIDE 16777249
KEYPRESS 16777249 "" '!'
PLAIN MODIFIER
SHORTCUT OVERRIDE 83 PASSING: false
NO SHORTCUT OVERRIDE 83

the following is the output from the case when there is no change and I press cmd + s
SHORTCUT OVERRIDE 16777249 PASSING: false
NO SHORTCUT OVERRIDE 16777249
SHORTCUT OVERRIDE 16777249 PASSING: false
NO SHORTCUT OVERRIDE 16777249
KEYPRESS 16777249 "" '!'
PLAIN MODIFIER
SHORTCUT OVERRIDE 83 PASSING: false
NO SHORTCUT OVERRIDE 83
SHORTCUT OVERRIDE 83 PASSING: false
NO SHORTCUT OVERRIDE 83
SHORTCUT OVERRIDE 83 PASSING: false
NO SHORTCUT OVERRIDE 83
KEYPRESS 83 "s" 'S'

Answer 17 · 2014-02-17T21:20:08.000Z

I get the same output. I'll try to put some more useful debug info to the Input class later.

Answer 18 · 2018-09-03T09:02:14.000Z

Hello, is there an update? 4.5 years later this is still present in latest Qt Creator :(

Answer 19 · 2018-09-05T15:04:24.000Z

Hello, is there an update? 4.5 years later this is still present in latest Qt Creator :(

@pvaibhav I haven't updated the code in a while. You try opening an bug report for Qt Creator if it's not reported there.

Answer 20 · 2018-10-10T14:33:50.000Z

A lot might have changed from 2014 to 2015.
QtCreator gives an option to "Pass Control Key" for FakeVim mode. (Tools -> Options -> FakeVim).
When you check that option Ctrl+s was passed to Qt.

Answer 21 · 2018-10-10T14:34:59.000Z

Hello, is there an update? 4.5 years later this is still present in latest Qt Creator :(

Tools -> Options -> FakeVim -> Check "Pass Control Key" should do the trick.

Answer 22 · 2018-10-11T10:45:57.000Z

Unfortunately that doesn't help (on a Mac). Cmd + S still clears out the whole line, ~~instead of saving the file~~ if there are no unsaved changes.

Answer 23 · 2018-10-18T21:13:09.000Z

@pvaibhav one workaround is to put map S <Nop> into the vimrc file used by Qt Creator