honzakral/django-threadedcomments

Incompatible to Django 2.0

larsrinn opened this issue · 1 comments

larsrinn commented

In Django 2.0 foreign key relations must have the parameter on_delete set: https://docs.djangoproject.com/en/2.0/releases/2.0/#features-removed-in-2-0
This is not the case for the parent field of the ThreadedComment model. To reflect the behaviour in Django 1.11, it would have to set to models.CASCADE

vdboor commented

Thanks! this is now merged.

  • 👍1