houdiniproject/houdini

[FEATURE] Meaningful variables names

JoaoVitorFarias opened this issue · 3 comments

Is your feature request related to a problem? Please describe.
I came across some variables that have not names meaningful, so that make the code less readable.

Describe the solution you'd like
I thought of some alternatives:
npo -> nonprofit
ba -> bank_account
tok -> token
acct -> account
es -> email_settings
ev -> event
rd -> recurring_donation
np -> nonprofit
ev_id -> event_id

Some of these variables changes were pointed in the issue #797
I would like to know what you think and if it is ok, I can work on that.

@JoaoVitorFarias I think some of these make sense to change. In other cases, I think, the shorter variable names are helpful shorthand for longer terms. What do you think @clarissalimab?

@wwahammy I'm always in favor of using the entire name instead of abbreviations, I think the benefit of clarity overcomes the benefit of typing less letters, and it also makes it easier to be searched. But that's just my personal opinion =)

Alright @JoaoVitorFarias, go ahead and make these changes 👍