Code fails on Venstar T4800 and T4900 Commercial Thermostats
Closed this issue · 3 comments
broswell commented
My Fixes
172,173c172
< if self._type != "commercial": #Commercial thermostats don't support "away"
< self.away = self.get_info("away")
self.away = self.get_info("away")
198,199c197
< #elif self.model == "COLORTOUCH":
< elif self.model == "VYG-4900-VEN" or self.model == "VYG-4800-VEN" or self.model == "COLORTOUCH":
elif self.model == "COLORTOUCH":
hpeyerl commented
I'm more likely to be able to handle this in a timely manner if you send a pull request. Thanks!
broswell commented
Never done one before. Will learn how!
Bob Roswell
broswell@syssrc.com
410-771-5544 ext 4336
Computer Museum Highlights<http://museum.syssrc.com/>
[syssrclogo_38years]
From: Herb Peyerl
Sent: Friday, February 14, 2020 11:12 AM
To: hpeyerl/venstar_colortouch <venstar_colortouch@noreply.github.com>
Cc: Bob Roswell <broswell@syssrc.com>; Author <author@noreply.github.com>
Subject: [EXTERNAL] Re: [hpeyerl/venstar_colortouch] Code fails on Venstar T4800 and T4900 Commercial Thermostats (#23)
I'm more likely to be able to handle this in a timely manner if you send a pull request. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hpeyerl_venstar-5Fcolortouch_issues_23-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABORPT66U5C4SRVAECUVGXDRC27ERA5CNFSM4KVKCOA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZRLYY-23issuecomment-2D586356195&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=IdFC6KVjMh11poEAtOxdlSfBzRH90l3lbPvEjfJS1FE&m=76R9WFqfnOwH3WiLGfbhL8Kr11DNxbR2d6ogcvObcy0&s=tugrqPiNxr98yivitf9AdLTFqlfdmtO6MAkhacG2tTY&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABORPT7YBRODSJW562V3US3RC27ERANCNFSM4KVKCOAQ&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=IdFC6KVjMh11poEAtOxdlSfBzRH90l3lbPvEjfJS1FE&m=76R9WFqfnOwH3WiLGfbhL8Kr11DNxbR2d6ogcvObcy0&s=7kmop6TOMcape153w4VLStBCtl5x3ZicXYaPFWxwBTA&e=>.
broswell commented
Hope I did the pull request properly. Sorry, Github newbie.
Bob Roswell
broswell@syssrc.com
410-771-5544 ext 4336
Computer Museum Highlights<http://museum.syssrc.com/>
[syssrclogo_38years]
From: Herb Peyerl
Sent: Friday, February 14, 2020 11:12 AM
To: hpeyerl/venstar_colortouch <venstar_colortouch@noreply.github.com>
Cc: Bob Roswell <broswell@syssrc.com>; Author <author@noreply.github.com>
Subject: [EXTERNAL] Re: [hpeyerl/venstar_colortouch] Code fails on Venstar T4800 and T4900 Commercial Thermostats (#23)
I'm more likely to be able to handle this in a timely manner if you send a pull request. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hpeyerl_venstar-5Fcolortouch_issues_23-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABORPT66U5C4SRVAECUVGXDRC27ERA5CNFSM4KVKCOA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZRLYY-23issuecomment-2D586356195&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=IdFC6KVjMh11poEAtOxdlSfBzRH90l3lbPvEjfJS1FE&m=76R9WFqfnOwH3WiLGfbhL8Kr11DNxbR2d6ogcvObcy0&s=tugrqPiNxr98yivitf9AdLTFqlfdmtO6MAkhacG2tTY&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABORPT7YBRODSJW562V3US3RC27ERANCNFSM4KVKCOAQ&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=IdFC6KVjMh11poEAtOxdlSfBzRH90l3lbPvEjfJS1FE&m=76R9WFqfnOwH3WiLGfbhL8Kr11DNxbR2d6ogcvObcy0&s=7kmop6TOMcape153w4VLStBCtl5x3ZicXYaPFWxwBTA&e=>.