hypertidy/silicate

crs structure is going to change

edzer opened this issue · 6 comments

edzer commented

You're using constructs like

> silicate:::get_projection.sfc
function (x, ...) 
{
    attr(x, "crs")[["proj4string"]]
}

but upcoming sf will change the structure of crs objects; see e.g. r-spatial/sf#1225 . I will allow for a $ method that extracts a proj4string from a WKT represenation, so please change this into

    attr(x, "crs")$proj4string

if you want to stay in the proj4string realm.

mdsumner commented

Thanks for the heads up, you're saying we need the sf $ overload to get basic metadata? Don't bother we don't use sf

edzer commented

Others do, and get breaking packages because of silicate. You're on CRAN.

mdsumner commented

Thanks! And sorry for grumbling ...

edzer commented

still the case on CRAN; package eixport breaks for this reason; FYI @ibarraespinosa

mdsumner commented

Nearly ready, new silicate should hit CRAN within a day or so.

ibarraespinosa commented