PreparedStatement preparedStatement may cause memory leakage.

Question

PreparedStatement preparedStatement may cause memory leakage.

afthabvp opened this issue 4 years ago · 6 comments

https://github.com/hypertrace/document-store/blob/main/document-store/src/main/java/org/hypertrace/core/documentstore/postgres/PostgresCollection.java
https://github.com/hypertrace/document-store/blob/main/document-store/src/main/java/org/hypertrace/core/documentstore/postgres/PostgresDatastore.java
PreparedStatement preparedStatement should be close in finally block or use try-with-resources.

Answer 1 · 2020-12-23T08:12:24.000Z

Thank you! Are you up for a PR on this? Otherwise we will fix it soon.

…

On Wed, 23 Dec 2020, 08:05 afthab vp, ***@***.***> wrote: *PreparedStatement preparedStatement* need to close in finally block or use try-with-resources. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#21>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAUQXUJ4KW5Y4R5UT43SWGJE3ANCNFSM4VGTYS4A> .

Answer 2 · 2020-12-23T12:17:57.000Z

@jcchavezs yeah, Is any access permission required to push the branch?

Answer 3 · 2020-12-23T12:24:30.000Z

Usual flow is that you fork the repo and open a PR against main.

…

On Wed, 23 Dec 2020, 13:18 afthab vp, ***@***.***> wrote: @jcchavezs <https://github.com/jcchavezs> yeah, Is any access permission required to push the branch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAQYXPMZFK65DLCTESDSWHNYHANCNFSM4VGTYS4A> .

Answer 4 · 2020-12-24T07:45:09.000Z

Thank you @jcchavezs

Answer 5 · 2021-01-07T07:50:06.000Z

@afthabvp I think, this PR - #23 - address this?

Answer 6 · 2021-03-22T10:54:51.000Z

Closing this as PR has been merged and part of releases.